-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LineHeightControl
unit tests
#61337
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
Flaky tests detected in c8579a7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8929256657
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @stokesman!
The refactoring looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a nice improvement 👍
What?
Updates unit test for
LineHeightControl
to use@testing-library/user-event
Why?
To test with greater parity to actual use (i.e. best practice). More specifically, to test the actual spin buttons rendered by
LineHeightControl
instead of simulating their use.How?
imports
userEvent
and uses it instead offireEvent
/act
.Testing Instructions